Sort:  
  • Trending
    • [-]
     7 years ago (edited)

    But its a package. Do you want me to fake it with more lines of code? If so, let me do it.

    Edit:
    Like this? https://github.com/bencagri/photon-bundle/blob/master/src/Service/PhotonService.php#L22

    Sorry friend, Im still trying to understand the criterias of the rules.

    $0.00
      Reply
      [-]
       7 years ago 

      I am not saying that you should fake it to get more lines of code, what I am trying to say is that most of the work is done by the package and I cannot see what you have done.

      $0.00
        Reply
        [-]
         7 years ago (edited)

        Ohh, Let me answer this question.

        Im using symfony mostly. In one of my projects, Image Manipulation was needed. So i wanted to create something for this.

        Then I said, ok, first create a wrapper for this, maybe some others may need to use it. So i created the photon wrapper.

        Back to our case, I need a bundle to use it in symfony. Cause Im also using some other components and packages (a lot).

        For example In this case, I will use monolog with this service to log non-accesseble images. So, I need symfony's dependency injection. Creating a service and overriding it would be solution for me.

        Maybe some other developers (for symfony) need this bundle. So that, I also put this.

        Conclusion,
        This is a Symfony Bundle. For only symfony framework. Some can implement it for Laravel or any other framework. Wrapper is standalone package.

        I hope I am clear now.

        Back to my first comment I said,I understand that, we shouldnt create packages for Symfony, Laravel or any other frameworks. And your reply (I cannot see what you have done.) supports this. Am I correct?

        $0.00
          Reply
          [-]
           7 years ago 

          Packages/modules/bundles for frameworks are totally fine, as long as they make sense. The problem I have with your bundle is that it does nothing more than wrapping your photon wrapper. You don't make use of Symfony's bundle functionality, like configuration for example.
          Your bundle has no advantage over simply using your photon wrapper directly. composer require bencagri/photon is everything you need to use it in your Symfony project.

          $0.00
            Reply
            [-]
             7 years ago 

            This is very clear respond. Thanks.

            $0.00
              Reply