You are viewing a single comment's thread from:
RE: 👨💻 #Proposal-86: Change Log - Community Pinned Posts
I have finally been able to integrate the changes into my test branch.
Your current changes can now be tested at steemit.moecki.online or steemit.steemnet.org.
I really like the toggle collapse function, especially the fact that the settings are saved for each community. Language strings would certainly need to be created for the final version. Or should it remain in English for everyone?
One suggestion: I would centre the CarouselDots. If there are only a few pinned posts, they otherwise hang on the left side.
<div class="carouselDots">
That's all I noticed at first glance. I will continue testing.
By the way, I had no problems at all with your previous changes
Goodness, these translations are time consuming! None of the content on any of these pages had been translated so it all needed doing! Just the Settings screen left to do now.
Good point - I'd forgotten about doing this. I'll add it to my to-do list (hopefully tomorrow).
I think that when I initially experimented with this, the central alignement didn't look right because of the "Show All Pinned" label. It meant that centre wasn't in the centre, it was just left of centre because that element's width is less than 100%.
This is how it would look if it was centered (without trying to adjust the "Show All Pinned" label.
I love it when things go smoothly! The next iteration is now available on GitHub so it should just be minor changes from now.
That's right. I had thought about that too. But I found it less ‘wrong’ than the left alignment. In the end it's ‘just’ a matter of taste. :-)