RE: [development] Cleaning up code for Fedora Packages
There are changes beyond README fixes. Ripping away stale code without knowing the codebase while ensuring that it doesn't break anything requires the same time investment. Such commits look simple, but they imply work with repo history and testing. Clearing technical debt is not the easy task to review without knowing how bad of good is the codebase, but my opinion that this type of work is no less valuable and time consuming that writing new code in terms of required expertise and impact for the project and future contributions. Otherwise I wouldn't spent 5 hours writing this post. =)
Perhaps it would be easier to review if I have mentioned that it all started, because dev environment didn't start up for unknown reason and I had to pick up codebase from scratch. Anyway, thanks for review. Is there a way to see my score?
Hey abitrolly,
I totally hear you. However, we need to follow the standard review questionnaire to make sure the every contribution treated equally. Most of the questionnaire consists of "code changes" as you may see.
We don't share the scores with contributors, we share the review answers normally but it's not applicable to your case.
Hi emrebeyler. If code cleanups are not applicable, then what category should I have filled this in? There is no separate
open-sourcetag that could cover this.@emrebeyler you were flagged by a worthless gang of trolls, so, I gave you an upvote to counteract it! Enjoy!!