You are viewing a single comment's thread from:

RE: DriveSoftwarePublisher | Software Publisher using Google Drive | Developement update #2

in #utopian-io6 years ago

Thanks for the contribution, @adam-saudagar! It's a great post with a lot of information - definitely an improvement over your previous one! A few thoughts:

  • You added all the features in one commit - not a good idea! It would be much better if you created a PR for each feature, with separate commits for each PR, and linked them instead. Currently it's hard to see which feature was implemented when and where, because it's all bundled together.
  • Sort of the same as above, but the commit has 29,705 deletions! A large part of this is more than likely not relevant to your contribution, so you could've created a separate commit/PR for this and not included it in the contribution for example.
  • The line width is pretty large in places. I think if you use ReSharper it should automatically wrap the lines that are too wide (but I could be wrong).
  • It's good that you add comments to your code, but sometimes I feel like it's a bit too much. For example I think this is already pretty clear without a comment
else if (docopt.Get("showversions").IsTrue)
{
    //show all versions in the project
    publisher.ShowVersions();
}
  • As I mentioned the quality of your contribution is good, but if you want to get the highest score then I would definitely recommend checking out a contribution like this one for example (the difference in score for the two answers is not large at all, so no pressure!).

It's a cool project born from a great idea, so I look forward to seeing more!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]