RE: Steem-Discord-Bot Announcement and Making it OpenSource.
Seems like you store channel ids hardcoded. It would better to keep this kind of things configurable, so other bot operators can install and use it with ease.
You have an assumption in here
if(ifollow[1].what[0] != null) {
that if what[0] is not null, it would be a follow. However, when you mute/ignore someone, you will get "ignore" here and the bot will send a notification like it was a follow.Seems like you have done everything in a single index.js file. To keep the debugging and maintenance simpler, modulizing functionality, seperating the discord bot stuff with the transaction parsing logic may help.
Why are the /node_modules stored in the GIT repository? I believe there is no need to vendorize dependencies for that project.
I had to score low on commit message question in the questionnaire because of the broad commit messages like #1, #2. Here is a simple guide about efficient commit messages.
It's a good start and I am totally hooked up with the idea of having a personal notification bot - instead of gina.
Looking forward to see more updates on that matter. :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for reviewing this post . Here are some points i made on your points :)
Thank you for your review, @emrebeyler!
So far this week you've reviewed 8 contributions. Keep up the good work!