You are viewing a single comment's thread from:

RE: KnackSteem update Overall Layout of Home, Editor, Preview and view for a particular post

in #utopian-io6 years ago

That seems a lot of work! :)

  • It seems the pull request was including unresolved conflicts.

  • There are duplicate commit messages in your branch's git history. It's a good practice to squash multiple commits into one for that kind of cases.

  • Looks like PrettyDate stops making things prettier after weeks. That would be good to have to make that work with months and years, too. (Btw, I know you just used the functionality already exists, however, pasting the original function to the your contribution post, I had to review that piece of code, too :))


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @emrebeyler! Keep up the good work!