You are viewing a single comment's thread from:

RE: [R: New Features on mindr] v.1.2.0 released: universal function and directory tree

in #utopian-io • 6 years ago

Thank you for your contribution @dapeng .

  1. typo. file name extension not extention
  2. Are you sure this is not typo return('NULLLL') as well?
  3. dir2, dir4 could be better named
  4. functions may be decomposed into smaller ones.
  5. Most functions could be unit tested and also you could configure your project on Travis-CI.com

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

Need help? Chat with us on Discord.

[utopian-moderator]

6 years ago in #utopian-io by
$10.75
  • Past Payouts $10.75
  • - Author $8.12
  • - Curators $2.62
23 votes
Reply 2
Sort:  
  • Trending
    • [-]
     6 years ago 

    Thank you for the helpful comments! NULLLL is deliberately misspelt for tracing (see the function count_space(). Although I agree that dir2 and dir4 could be better named, such names are quite popular in R community. For examples, read.csv2()is a built-in function.

    Many thanks!

    $0.00
      Reply
      [-]
       6 years ago 

      Thank you for your review, @justyy! Keep up the good work!

      $0.00
        Reply