You are viewing a single comment's thread from:
RE: Beem 0.19.55 - 3 new functions for SBD to rshares/vote_pct calculations
Thank you for your contribution. Nice to have these calculations in the beem library and +1 for the unit tests! The only thing I may 'complain' is the inconsistency of the letter cases for SBD in get_vote_pct_for_SBD and sbd_to_vote_pct.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Yeah this kinda bugs me as well, but I just kept to the style depending on the submodule. The only other function in the beem.account module with sbd in it's name has it written in capital letters (see here), and in the beem.steem module sbd is always written lowercase. I just sticked to what already existed so it is an inconsistency trying to keep consistency.
Thanks for your review
Thank you for your review, @justyy!
So far this week you've reviewed 2 contributions. Keep up the good work!