You are viewing a single comment's thread from:

RE: Steem-Lite front end update - comedyopenmic website

in #utopian-io6 years ago

Thank you @hispeedimagins for your contribution!

  1. Some of your style sheets can be re-used e.g. instead of appearing in many HTMLs, you could store it in a .css file
  2. Same goes to some JS code, for example, your Google Analytics
  3. Instead of asking user to configure the ID in the config file, you could simply obtain this by e.g. analysing the URL e.g. in the form of .../@steem_id
  4. Please start using Pull Requests to group your commits and make your commit history a bit clean.
  5. some code are appearing here and there e.g. loadMoreNowPyou could refactor those common-used functions.
  6. some commented-out code are commited .

+1 for using React!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you.

I don't think I have any css code laying around in html files, ill check it.

lol no you configure the id if you want to use it as a private website, you cannot use that in a private website. Like a wordpress blog.

loadmorenowp has to be changed, I know that but it is a bit tricky and I will change it with a component in the next update. As all js is shared enough to cause problems among the blog and the profile blog.

ahh yes, the commented out code. I always forget it, hehe.

Thank you for your review, @justyy! Keep up the good work!