Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
&& instead of elses is because I did a straight port from Python to JS https://github.com/biophil/pocket/blob/master/blockchain_reader.py#L135 and I haven't yet gone thru code optimization and rewrite as the primary goal is to get the JS version up and running with the same logic. So keeping things as close as possible to the original makes it easier if I spot a behavior that is different from the Python version.
The tests were very useful as I get to change code here and there as I go, this allowed me to make sure that I didn't break anything with the new changes and refactor.
hahaha, I'm often working on a train and then forget to commit as I rush down, three days later... can't remember things. Advice taken :-)
I do almost everything with Docker as it makes it so much easier to deploy or migrate
Congratulations! This post has been upvoted from the communal account, @minnowsupport, by QuocHuy [witness] from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, theprophet0, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows. Please find us at the Peace, Abundance, and Liberty Network (PALnet) Discord Channel. It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.
If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: 50SP, 100SP, 250SP, 500SP, 1000SP, 5000SP. Be sure to leave at least 50SP undelegated on your account.
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1024
New receiving account balance: 438
Fee: 1
Steem trxid: f31af5cd19747f24748861cef6aac54dc9c23be2
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1024
New receiving account balance: 438
Fee: 1
Steem trxid: f31af5cd19747f24748861cef6aac54dc9c23be2
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1013
New receiving account balance: 448
Fee: 1
Steem trxid: edd1a6886e132bcfce806a5fc9fffdfb60b49fd3
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1013
New receiving account balance: 448
Fee: 1
Steem trxid: edd1a6886e132bcfce806a5fc9fffdfb60b49fd3
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1011
New receiving account balance: 449
Fee: 1
Steem trxid: 727c155978762036bb2913858b9ed211582133c0
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1011
New receiving account balance: 449
Fee: 1
Steem trxid: 727c155978762036bb2913858b9ed211582133c0
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1009
New receiving account balance: 450
Fee: 1
Steem trxid: 5637ac529890d3a8ddcdd44cd2fd7b803e91a678
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
Successful Send of 400
Sending Account: steemulant
Receiving Account: quochuy
New sending account balance: 50
New receiving account balance: 1408
Fee: 1
Steem trxid: 8c01de2469c409ab1093ad02fdcdae58f514fe19
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
Successful Send of 750
Sending Account: pocketjs
Receiving Account: quochuy
New sending account balance: 44
New receiving account balance: 2157
Fee: 1
Steem trxid: 270299ff3460d07fb4358077e8dcff5a175681ef
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command: pocketsend:number_of_token@recipient_name,memo for example to send 10 tokens to @pocketjs, make a comment starting with: pocketsend:10@pocketjs,This is a gift
It's nice to revive project and not let them decay!
Let's hope it will be used :p
Let's go for the review:
Since the account doesn't have much Steems on it I'll write it: https://github.com/quochuy/pocketjs/commit/aefd1a49738bf72c926201b7da04e735ec25e42d#diff-e22b50e740e102c8de5e858dbcd7753dL6 => Never ever post your private keep! Github archives everything :p. You better change it now :D
https://github.com/quochuy/pocketjs/blob/master/bot/confirmer.js#L56 => Any particular reason for not using
&&since you don't have anyelses?https://github.com/quochuy/pocketjs/tree/master/bot/test => You have a lot of tests and there are not useless this is awesome !
https://github.com/quochuy/pocketjs/commit/92f21722b6b30d12fdff588407789f55cf3a1a66 => Try to do a better job about your commits ha ha,
can't remember... :-P,miscthis is not serious, or havingValidatororAdd configtwice. You can be more precise. Good comments are free!It's nice to add a docker config. Really cool.
This a great job overall!
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
@gregory.latinier ARG! I thought I filtered out that from the history already! Thanks for letting me know!
And thanks for the very thorough review!
That was fast. Congrats @quochuy <3
To answer the other questions:
Thanks again @gregory.latinier
Hey @quochuy
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Congratulations! This post has been upvoted from the communal account, @minnowsupport, by QuocHuy [witness] from the Minnow Support Project. It's a witness project run by aggroed, ausbitbank, teamsteem, theprophet0, someguy123, neoxian, followbtcnews, and netuoso. The goal is to help Steemit grow by supporting Minnows. Please find us at the Peace, Abundance, and Liberty Network (PALnet) Discord Channel. It's a completely public and open space to all members of the Steemit community who voluntarily choose to be there.
If you would like to delegate to the Minnow Support Project you can do so by clicking on the following links: 50SP, 100SP, 250SP, 500SP, 1000SP, 5000SP.
Be sure to leave at least 50SP undelegated on your account.
@quochuy
Thanks for the information
Thx for this article! really interesting.
that follow the projects that make us grow more on the platform
pocketsend:11@steemulant,test
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1024
New receiving account balance: 438
Fee: 1
Steem trxid: f31af5cd19747f24748861cef6aac54dc9c23be2
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1024
New receiving account balance: 438
Fee: 1
Steem trxid: f31af5cd19747f24748861cef6aac54dc9c23be2
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy
pocketsend:11@steemulant,test
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1013
New receiving account balance: 448
Fee: 1
Steem trxid: edd1a6886e132bcfce806a5fc9fffdfb60b49fd3
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 11
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1013
New receiving account balance: 448
Fee: 1
Steem trxid: edd1a6886e132bcfce806a5fc9fffdfb60b49fd3
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy
pocketsend:2@steemulant,test
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1011
New receiving account balance: 449
Fee: 1
Steem trxid: 727c155978762036bb2913858b9ed211582133c0
Thanks for using POCKET! I am running this confirmer code.
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1011
New receiving account balance: 449
Fee: 1
Steem trxid: 727c155978762036bb2913858b9ed211582133c0
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy
pocketsend:2@steemulant,test
Successful Send of 2
Sending Account: quochuy
Receiving Account: steemulant
New sending account balance: 1009
New receiving account balance: 450
Fee: 1
Steem trxid: 5637ac529890d3a8ddcdd44cd2fd7b803e91a678
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy
pocketsend:400@quochuy
Successful Send of 400
Sending Account: steemulant
Receiving Account: quochuy
New sending account balance: 50
New receiving account balance: 1408
Fee: 1
Steem trxid: 8c01de2469c409ab1093ad02fdcdae58f514fe19
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy
pocketsend:750@quochuy
Successful Send of 750
Sending Account: pocketjs
Receiving Account: quochuy
New sending account balance: 44
New receiving account balance: 2157
Fee: 1
Steem trxid: 270299ff3460d07fb4358077e8dcff5a175681ef
Someone sent you some POCKET tokens. POCKET is an experimental sub-token system which operates on the Steem blockchain. It's like having a custom token without SMT. You can also send some to someone else by just commenting on a post with the following command:
pocketsend:number_of_token@recipient_name,memofor example to send 10 tokens to @pocketjs, make a comment starting with:pocketsend:10@pocketjs,This is a giftI am running Pocket-JS confirmer code. by Steem Witness @quochuy