Fixed squeezed replies issue and large area of focus for reading time issue

in #utopian-io7 years ago

In this development contribution I want to report two issues I fixed for the amazing Busy.org website.


contribution10.png

The first issue

was that when there were a lot of replies, the comments would get squeezed on the right side and eventually would look bad or could not be readable anymore.

Here is how that looked like:
busy-issue-1088.png

The changes I made:

  • added CSS class Comment__replies--never-indent
  • put that class in comments starting with 5th level
  • removed @media @small from .Comment__text so that comment avatars would show up after 5th level
  • updated the hardcoded .Comment__replies--no-indent margin to use the @comment-text-offset-small var

What this does is that the comment replies will not indent anymore after the 5th level of replies.

The pull request: https://github.com/busyorg/busy/pull/1090
The issue it fixes: https://github.com/busyorg/busy/issues/1088

Here is also a screenshot of the merged pull request:
busy-pull-1090.png

The second issue

was that the "post reading time" tooltip had a large area of focus, so that it would appear even if you were having the cursor over the left separating dot.

Here is a gif to illustrate the issue:
busy-issue-1107.gif

Thanks @espoem for this gif and for reporting both issues.

The changes I made:

  • moved the CommentFooter__bullet outside of the Tooltip
  • made small CSS changes to keep the existing style given the above change

With the above changes, the "reading time" tooltip would appear when expected.

The pull request: https://github.com/busyorg/busy/pull/1111
The issue it fixes: https://github.com/busyorg/busy/issues/1107

Here is also a screenshot of the merged pull request:
busy-pull-1111.png



Posted on Utopian.io - Rewarding Open Source Contributors

Sort:  

Thank you for the contribution. It has been approved.

Simply well done.

You can contact us on Discord.
[utopian-moderator]

Thank you for contributing to Busy.

With pleasure, I also learn a lot doing it :)

Hey @sirrius I am @utopian-io. I have just upvoted you!

Achievements

  • You have less than 500 followers. Just gave you a gift to help you succeed!
  • Seems like you contribute quite often. AMAZING!

Community-Driven Witness!

I am the first and only Steem Community-Driven Witness. Participate on Discord. Lets GROW TOGETHER!

mooncryption-utopian-witness-gif

Up-vote this comment to grow my power and help Open Source contributions like this one. Want to chat? Join me on Discord https://discord.gg/Pc8HG9x

I send you a big Hug @Sirrius!! May the New Year bring you only satisfactions in projects and life!! My best regards always for you!!
Cheers!!! ;D

Congratulations @sirrius! You received a personal award!

Happy Birthday! - You are on the Steem blockchain for 2 years!

You can view your badges on your Steem Board and compare to others on the Steem Ranking

Vote for @Steemitboard as a witness to get one more award and increased upvotes!