You are viewing a single comment's thread from:

RE: SteemFriends: Showing articles written by a user between 2 dates

in #utopian-io6 years ago

Thanks for the contribution, @magicmonk! That's definitely a cool feature to have and should be useful to people looking for some older posts - great work!

Some feedback: the indentation of your code seems pretty inconsistent in places. Sometimes it's 2, 4, 8 or even 0. I would recommend you stick to the best practices of each language (e.g. HTML would be 2 spaces).

Another thing I would like to remark is that some comments are not very useful.

if ($voter&&$mode=="upvote") {
// get list of results
$results = $articlelistmodel -> gethistory($date,$todate,$voter);

It should be pretty obvious what you are doing here, so there isn't much need to add a comment describing what is happening imo.

Finally, since you made a pull request (which is great) it would be nice if you could link it in the body of your contribution, but that's just for our convenience of course.

Good to see you back contributing and working on improving SteemFriends!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you so much amosbastian. Your reviews are very useful and detailed as always. Much appreciated. Have linked the pull request in the article and will definitely watch the indenting and commenting in the future. Thank you very much.

Thank you for your review, @amosbastian!

So far this week you've reviewed 11 contributions. Keep up the good work!