Sort:  

Thank you for your contribution. I'm glad that BEEM is under active development regarding bug-fixes and new features.

Regarding the method beneficials, you implemented in cli.py, could it be better if you extract the logics and put it somewhere not in the cli.py because it looks to me that the cli.py is the command line utility that should only handle the command line options etc - all other logics could be moved to other modules for better code resusablilty and code testing.

And also, beneificals and etc contains quite a lot of code with no comments.

How do you make sure these functions beneificals, GetWitnessesare not broken? e.g. I haven't seen unit tests covering these two newly-added methods.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Thank you for your review, @justyy! Keep up the good work!

Glad to see someone continue my work on pysteem/piston-lib and piston-cli. Looking forward to using it again. Much love for command line tools :D

This post has been just added as new item to timeline of beem on Steem Projects.

If you want to be notified about new updates from this project, register on Steem Projects and add beem to your favorite projects.

Hi, @holger80!

You just got a 1.82% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.

Hi @holger80!

Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your UA account score is currently 7.223 which ranks you at #71 across all Steem accounts.
Your rank has not changed in the last three days.

In our last Algorithmic Curation Round, consisting of 260 contributions, your post is ranked at #154.

Evaluation of your UA score:
  • Your follower network is great!
  • The readers appreciate your great work!
  • Try to work on user engagement: the more people that interact with you via the comments, the higher your UA score!

Feel free to join our @steem-ua Discord server

pyyaml is currently missing as dep.

pip install pyyaml

I will fix this in the next release.

Posted using Partiko Android

Hey, @holger80!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!