You are viewing a single comment's thread from:

RE: update for beem - post, reply and beneficiaries commands added to beempy

in #utopian-io6 years ago

Thank you for your contribution. I'm glad that BEEM is under active development regarding bug-fixes and new features.

Regarding the method beneficials, you implemented in cli.py, could it be better if you extract the logics and put it somewhere not in the cli.py because it looks to me that the cli.py is the command line utility that should only handle the command line options etc - all other logics could be moved to other modules for better code resusablilty and code testing.

And also, beneificals and etc contains quite a lot of code with no comments.

How do you make sure these functions beneificals, GetWitnessesare not broken? e.g. I haven't seen unit tests covering these two newly-added methods.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!