You are viewing a single comment's thread from:

RE: KURE Curation Community Network - Update 10 - Comments! View, Write and Post Comments!

in #utopian-io6 years ago (edited)

Hello, don't be upset, 73 is still very high (in my standard). I think you can improve your next contribution in the following area:

  1. unit tests. No tests are found to cover your changes. I would expect to see tests in any size of the projects, not to mention this one.
  2. some comments are not necessary, for example, Sort the Comments, comments should be clear and add additional values.
  3. The errors shown to console when users are not login (as I mentioned earlier) ==> indicates that the code can be improved in terms of robustness.

Don't take these as criticisms, you are already doing very good job and I am hoping to see more from you soon.

Sort:  

Thanks, I will take that into consideration. What about "The post is of decent quality."? You didn't answer me on that point. Your review and that of 3 other reviewers in utopian don't match on that category, as they all rate the posts I make as "high".

Look at my first post that got an "decent" rating:

https://steemit.com/utopian-io/@krnel/kure-development-update

It's much different than this above post, and all the others before that (update 2-9).

Look at all the other posts where I increased the quality of the post, and got a "high":

https://steemit.com/utopian-io/@krnel/kure-development-update-2-managing-users
https://steemit.com/utopian-io/@krnel/kure-development-update-3-permissions-and-communities-you-joined
https://steemit.com/utopian-io/@krnel/kure-development-update-4-browsing-content-and-adding-to-communities
https://steemit.com/utopian-io/@krnel/kure-development-update-5-home-page-filter-content-and-personalized-sidebar
https://steemit.com/utopian-io/@krnel/kure-development-update-6-view-content-and-communities-request-to-join-communities-and-approve-deny-requests
https://steemit.com/utopian-io/@krnel/kure-development-update-7-now-online-with-individual-community-group-pages-to-view-and-join-communities
https://steemit.com/utopian-io/@krnel/kure-development-update-8-ui-ux-candy-mobile-menu-infinite-scroll-and-lots-of-fixes
https://steemit.com/utopian-io/@krnel/kure-development-update-9-upvoting-content-and-pages-for-blogs-feeds-tags-created-hot-promoted-and-trending

And then look at this post you reviewed again. Why does it fall into "decent" when it is of high quality like all the others (except the first post)? I don't understand how you can rate it as "decent" only. Please elaborate on why you judged it as only decent, in contrast to 3 of your colleagues who rate my post quality as high.

Thank you.

I understand your points. The decent and high are quite subjective, that depends on the opinions of the reviewer. I am sorry that I felt it is ‘decent’ which is still very good.
Utopian does not have a clear guidance on when to rank ‘decent’ and when to rank ‘high’, if there is, and if it is a very clear criteria I am sure every reviewers will follow and mark the same.

Ok. I had asked previously "What would be a high quality post for you?" Can you show me a high quality post so I know what I need to do?

If there is no criteria from utopian for this category of quality post, how does one judge it one way or another?

Thanks.